epiforecasts / scoringutils

Utilities for Scoring and Assessing Predictions
https://epiforecasts.io/scoringutils/
Other
48 stars 21 forks source link

Make all internal columns, in particular `forecast_id`, more robust by prefixing it with "scoringutils_" #927

Open nikosbosse opened 2 months ago

nikosbosse commented 2 months ago

quantile_to_interval_numeric(), for example, makes use of an internal forecast_id column. This might cause issues if there is already a forecast_id column in the input.

We should likely prefix all internal columns with "scoringutils_" to avoid those issues + document this design choice somewhere.

seabbs commented 2 months ago

Yes makes sense though seems a little long. I typically use . As a prefix but people might conceivably name their variables using a dot