epiforecasts / socialmixr

R package for deriving social mixing matrices from survey data.
http://epiforecasts.io/socialmixr/
Other
38 stars 11 forks source link

First round of review #31

Closed Bisaloo closed 2 years ago

Bisaloo commented 2 years ago

I mostly focused on the packaging side and did not really dive into the code to check if it does what's it's supposed to do (yet!).

This PR will cause conflicts in all the currently opened PRs. If you want to merge them, you should do it before you merge this one to avoid causing headaches to contributors.

sbfnk commented 2 years ago

Thanks! All other PRs have been merged now.

Bisaloo commented 2 years ago

The conflicts are too complex for me to be sure I'm not introducing any bugs. I'll submit a new PR from the current codebase.