epignatelli / navix

Accelerated minigrid environments with JAX
Apache License 2.0
103 stars 7 forks source link

Entities should have only members, not `@property` #85

Open epignatelli opened 2 months ago

epignatelli commented 2 months ago

For clarity and to minimise entropy, entities should not implement @property, but full members.

For example:

class Foo(Entity):
  walkable: Array = jnp.asarray(False)

While this can be problematic for broadcasting, when entities are batched, the create method should take care of that.