Blank confirmation dialog pops up when closing editing window if no changes made

[GoogleCodeExporter]

What steps will reproduce the problem? (in some environments)
1. Select a project and click the 'Edit' button
2. Close the editing window without making any changes

What is the expected output? What do you see instead?
Expect the editing window to close quietly and to be returned to the main 
projects page. Instead, the 'Would you like to publish your changes?' 
confirmation dialog pops up, but with no question text in it - just the 'OK' 
and 'Cancel' buttons.

What version of the product are you using? On what operating system?
Latest XOT trunk checkout on Ubuntu 10.04 LTS (development) / SLES 11 
(production).

Please provide any additional information below.
I've seen this on both my development environment and our production host, 
although I notice the sandpit at http://www.techdisplayxerte.info/ isn't 
affected. It's caused by a couple of space characters creeping into the output 
of website_code/php/versioncontrol/template_close.php, causing the check for 
response text in function file_need_save() (in template_management.js) to 
always return true.
Cleaning the output buffer of template_close.php fixes the problem. Patch 
attached.

Original issue reported on code.google.com by tonyjbut...@gmail.com on 21 Jun 2011 at 11:14

Attachments:

• confirm.patch

[GoogleCodeExporter]

techdisplayxerte probably isn't affected as it is unlikely to be running the 
latest code... I think you're referring to some of the 'alert' calls which have 
been left in the javascript and should only popup when things perhaps go wrong. 
At least, I see these here.

Original comment by ginger...@gmail.com on 27 Sep 2011 at 6:09

[GoogleCodeExporter]

i can confirm this behaviour - I've tried to track down where the output is 
coming from but I can't - oddly the behaviour seems a bit different on chrome 
(where it shows as a normal alert() popup) and firefox (where it seems to 
appear as part of the flash widget). 

As far as I can tell I've put in place as many string.trim()'s as I can in 
javascript to squelch out empty output - which has removed 2-3 popups - but i 
can't get rid of the last one unfortunately.

Original comment by ginger...@gmail.com on 28 Sep 2011 at 7:46

• Changed state: Accepted

[GoogleCodeExporter]

This has already been fixed twice

Original comment by Patrick....@googlemail.com on 1 Oct 2011 at 3:34

[GoogleCodeExporter]

I think some blank spaces have/were/are being added onto the root/database.php 
file when it's generated from the setup wizard.

i.e.

<?php
....blah blha blah bla
?>[xxx]

(Where [xxx] are the spaces which are added in and shouldn't be there).

I've removed the closing ?> from the setup/database.txt file which should solve 
the issue, but I'm not sure.

Original comment by ginger...@gmail.com on 3 Oct 2011 at 10:52

[GoogleCodeExporter]

Original comment by juliante...@gmail.com on 5 Mar 2012 at 11:29

• Changed state: Done