Please also see this slack message for clarity on the issues
issue 216
I removed unused and broken code that added an Iframe to the Modal causing a focus flow issue.
Gplus is no longer a social service
Facebook code contained no href
The control flow is now fixed according to manual testing and Silktide.
I have also added a focus flow trap to the modal using JS so that the user explicitly has to close the modal before they can tab any other page elements.
Please also see this slack message for clarity on the issues
issue 216
I removed unused and broken code that added an Iframe to the Modal causing a focus flow issue. Gplus is no longer a social service Facebook code contained no href
Neither of the above services were visible to the user so I assume they are unrequited. Please see this ticket https://github.com/epimorphics/ppd-explorer/issues/216
issue 218
This fix ensures that the help modal is immediately in focus after the help action button has been clicked Please see this ticket https://github.com/epimorphics/ppd-explorer/issues/218
For both of the above issues
The control flow is now fixed according to manual testing and Silktide.
I have also added a focus flow trap to the modal using JS so that the user explicitly has to close the modal before they can tab any other page elements.