search

epimorphics / sapi-client-ruby

A client library to help Ruby code to invoke Sapi-NT API endpoints
MIT License
0 stars 0 forks source link

Replace automated Faraday logging #48

Closed ijdickinson closed 11 months ago

ijdickinson commented 2 years ago

I noticed while looking at https://github.com/epimorphics/regulated-products/issues/519 that we're still relying on Faraday to log calls to the remote API (see instance.rb, line 58).

Following recent conversations with @andrew-pickin-epi, I've moved away from Faraday's built-in logger, and instead make an explicit call to the logger to record the interaction.

Specifically, ops would like to see one line in the log that records, in one single JSON log entry:

There's an example of this change in the data_services_api, for reference.

tomguilbert commented 1 year ago

@jonrandahl should this be part of the app enhancements backlog? If so I can't add the 'app' label

jonrandahl commented 11 months ago

This can be closed as was previously marked as resolved in multiple locations:

and subsequently linked tickets and PR's from above.