epinowcast / epidist

An R package for estimating epidemiological delay distributions
http://epidist.epinowcast.org/
Other
9 stars 4 forks source link

Within-code clarity on what e.g. `family` refers to #198

Open athowes opened 1 month ago

athowes commented 1 month ago

Here it's a challenge whether things are family as input or epidist_family as input (likewise formula or epidist_formula)

_Originally posted by @athowes in https://github.com/epinowcast/epidist/pull/183#discussion_r1689463807_

Within the code, I am sometimes confused whether something is say a family (brmsfamily object) or the result of a call to epidist_family.

athowes commented 1 month ago

Additionally, whether functions should take the family or epidist_family version e.g.

Should this instead be a brmsfamily object? Could still extract out the dpars

_Originally posted by @athowes in https://github.com/epinowcast/epidist/pull/183#discussion_r1689469410_

athowes commented 3 weeks ago

Came up here: https://github.com/epinowcast/epidist/pull/242#discussion_r1717141121. Sam suggests one option here is to put the formula (or family) into the epidist_ version.