search

epinowcast / epidist

An R package for estimating epidemiological delay distributions
http://epidist.epinowcast.org/
Other
9 stars 4 forks source link

Refactor of `observe_process` #291

Open athowes opened 1 week ago

athowes commented 1 week ago

observe_process creates columns ptime_daily and stime_daily. This seems to be strange to me. What if the columns are already daily (e.g. https://github.com/epinowcast/epidist/pull/52#discussion_r1742271807)? What if we want something other than daily level of censoring? This suggests function refactoring to me.

seabbs commented 1 week ago

The current approach is 100% hardcoded for the original paper we need to think carefully about the preprocessing i.e should this function even exist and if it does in what form/how exposed to the user (i.e is it in post on a model object or preprocessing)