Open athowes opened 3 weeks ago
one of this and #306 seems like a duplicate. What do you mean by no model? Do you mean no linear model but still a parameter (i.e sigma vs no sigma)? if so can you clarify and add in the already discussed option of enforcing that we always have a linear model (i.e the default is sigma ~ 1
.
There are 3 cases:
dpar
: then it'll be called Intercept_sigma
dpar
(https://github.com/epinowcast/epidist/issues/305): then it'll just be called sigma
dpar
set to a constant (https://github.com/epinowcast/epidist/issues/306): then it'll be called sigma
but will be set to a constantI agree it's a bit confusing.
As of PR #282 we have code like:
Within
epidist_family_prior.lognormal
. This is to deal with 3 cases:dpar
dpar
dpar
set to a constantIdeally we should be automating parts of this. Specifically here, setting the prior in the case that there is no model. Can this be obtained as a tranformation of the case where there is a model? And then it can be done at a higher level e.g. in
epidist_prior
.This also flags issues with the priors being connected to link functions, which can be changed by the user, and we don't currently account properly for.
Edit: we have also already discussed another issue which would provide a solution to this https://github.com/epinowcast/epidist/issues/266. Summary: just enforce there is always a model
~ 1
. This is mentioned in #307.