epinowcast / epidist

Estimate epidemiological delay distributions with brms
http://epidist.epinowcast.org/
Other
12 stars 5 forks source link

Make logo transparent outside hex for dark mode #363

Closed athowes closed 4 weeks ago

athowes commented 1 month ago
          (look in dark mode)

Originally posted by @seabbs in https://github.com/epinowcast/epidist/issues/353#issuecomment-2388331975

athowes commented 1 month ago

FWIW I don't think a logo having whitespace on darkmode is "high priority"

seabbs commented 1 month ago

IMO this is high as it represents a reduction in package quality of what we had previously/a bug if we had seen it in #361 we wouldn't have merged that PR.

We can't seriously share the package whilst its here in my view

athowes commented 1 month ago

We can't seriously share the package whilst its here in my view

I'd say this is overly strong, but fair enough.

The challenge here is having a figure which hits the boundaries of the hex. With white_around_sticker = FALSE it leaves plot outside the sticker. To me having the plot not hit the bounds of the sticker makes the plot too small.

seabbs commented 1 month ago

This wasn't an issue previously right so reverting is something to consider if we want a quick fix (and could just revert the plot size change). I struggle to see how this can't be a very fixed issue elsewhere in package land though.

athowes commented 1 month ago

Solution is here https://stackoverflow.com/questions/60426922/trim-around-hexagon-shape-with-hexsticker

athowes commented 1 month ago

I think easy fix will do soon

athowes commented 1 month ago

Solution is here https://stackoverflow.com/questions/60426922/trim-around-hexagon-shape-with-hexsticker

You might want to consider this over at EpiNow2 as looks to me like there will be same issue