search

epinowcast / hashprng

Hash-based Matching Pseudo-Random Number Generation
https://hashprng.epinowcast.org/dev/
Other
2 stars 0 forks source link

overhaul with new approach #21

Open pearsonca opened 2 months ago

pearsonca commented 2 months ago

Chucks the old approach, in with the new.

pearsonca commented 2 months ago

I can deal with the linting issues, but not sure about the test-coverage - my end, the tests work (though they did some troubleshooting).

seabbs commented 2 months ago

et.hash(hash, get(".hash.salt", envir = parent.frame()))

  1. ├─base::set.seed(...)
  2. └─base::readBin(digest(obj, algo = "xxhash32", raw = TRUE), "integer")
  3. └─base::file(con, "rb")

Nice! Will take a look tonight.

This is the error. Is the test CI missing a dependency?

pearsonca commented 2 months ago

This is the error. Is the test CI missing a dependency?

Not sure how that gets specified - the DESCRIPTION and NAMESPACE dependencies correctly connect to digest. Whereabouts do CI package dependencies live? Presumably somewhere in the YAML configs.

seabbs commented 2 months ago

If they are in the DESCRIPTION it should pick them up. Platform specific issue maybe?

seabbs commented 1 month ago

s live? Presumably somewhere in the YAML configs.

Yes if different to the DESCRIPTION ones