Issue #84: Prune not helpful to arg flow maths

epinowcast / primarycensored

Primary event censored distributions in R and Stan.

https://primarycensored.epinowcast.org/

Other

7 stars 1 forks source link

Issue #84: Prune not helpful to arg flow maths #116

Closed seabbs closed 1 week ago

seabbs commented 1 week ago

Description

This PR closes #84. It removes some lines of maths that don't seem useful to the reader and weren't in all analytical solutions. It also removes the acknowledgement section from the vignette as we already have this contribution flagged via the all contributors bot.

Checklist

[x] My PR is based on a package issue and I have explicitly linked it.
[x] I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
[x] I have read the contribution guidelines.
[x] I have tested my changes locally.
[x] I have added or updated unit tests where necessary.
[x] I have updated the documentation if required.
[x] My code follows the established coding standards.
[x] I have added a news item linked to this PR.
[ ] I have reviewed CI checks for this PR and addressed them as far as I am able.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.29%. Comparing base (7180ddc) to head (8aa738b). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #116 +/- ## ======================================= Coverage 99.29% 99.29% ======================================= Files 10 10 Lines 427 427 ======================================= Hits 424 424 Misses 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

seabbs commented 1 week ago

LGTM (self-review)