epinowcast / primarycensored

Primary event censored distributions in R and Stan.
https://primarycensored.epinowcast.org/
Other
7 stars 1 forks source link

Small suggestions on getting started vignette #43

Closed athowes closed 1 month ago

athowes commented 1 month ago

Nice vignette. Aside from these small suggestions:

athowes commented 1 month ago

image

Given that this is a discretisation should the x-axis here be 0, 1, 2, ...?

seabbs commented 1 month ago

Given that this is a discretisation should the x-axis here be 0, 1, 2, ...? Yes

seabbs commented 1 month ago

In general I'm a bit confused about the package's position on accounting or not accounting for secondary event censoring within the functions. All the names being like primarycensored... (when it's maybe primary, secondary, and truncation) is a bit odd

So the reason here is that the primary event handling is the special bit and the secondary event stuff is just handled in the same way that it would be normally. That being said if you can tighten this comment up a bit maybe make an issue (I'm not really sure what action to take on this at the moment) and obviously any work to resolve would be welcome.