Closed athowes closed 1 month ago
Given that this is a discretisation should the x-axis here be 0, 1, 2, ...?
Given that this is a discretisation should the x-axis here be 0, 1, 2, ...? Yes
In general I'm a bit confused about the package's position on accounting or not accounting for secondary event censoring within the functions. All the names being like primarycensored... (when it's maybe primary, secondary, and truncation) is a bit odd
So the reason here is that the primary event handling is the special bit and the secondary event stuff is just handled in the same way that it would be normally. That being said if you can tighten this comment up a bit maybe make an issue (I'm not really sure what action to take on this at the moment) and obviously any work to resolve would be welcome.
Nice vignette. Aside from these small suggestions:
primarycensored
... (when it's maybe primary, secondary, and truncation) is a bit odd