epinowcast / primarycensored

Primary event censored distributions in R and Stan.
https://primarycensored.epinowcast.org/
Other
7 stars 1 forks source link

Better truncation handling #44

Closed seabbs closed 1 month ago

seabbs commented 1 month ago

Description

This PR partly addresses #34 and some concerns in #37 about the handling of truncation. It moves to using normalisation outside the integral everywhere rather than just in the vectorised code. As @SamuelBrand1 pointed out this is more correct.

It also

I investigated using xc and found this made the integral fail to solve at any tolerance level.

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.51%. Comparing base (74c2c8c) to head (5727045). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #44 +/- ## ========================================== + Coverage 99.48% 99.51% +0.03% ========================================== Files 6 6 Lines 194 207 +13 ========================================== + Hits 193 206 +13 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.