Closed seabbs closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.62%. Comparing base (
c81f6dc
) to head (2d62937
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This PR closes #34.
Under the hypothesis that more work has been put into the ODE solvers vs the integrator and that they may therefore be more stable, I recharacterised the integral as an ODE problem and solved it using the
ode_rk45
solver (likely worth exploring other options as well as tolerances). This appears to give a 4-5 times speed up and on the test data has no stability issues (i.e no chains out of 600 failed).I am very unclear as to exactly why apart from above logic about dev time spent.
As part of testing this I have made the simulated logic significantly harder (a mix of window lengths and observation times).
Checklist