epinowcast / primarycensored

Primary event censored distributions in R and Stan.
https://primarycensored.epinowcast.org/
Other
7 stars 1 forks source link

Issue 85: Add infrastructure for analytical solutions in R #87

Closed seabbs closed 3 weeks ago

seabbs commented 3 weeks ago

Description

This PR partially closes #85 by adding infrastructure in R for introducing analytical solutions. It also adds skeletons for the current solutions but does not add the analytical solutions themselves.

Checklist

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 90.47619% with 6 lines in your changes missing coverage. Please review.

Project coverage is 98.06%. Comparing base (5c23d7a) to head (9a48117). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/primary_censored_dist.R 86.04% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #87 +/- ## ========================================== - Coverage 99.67% 98.06% -1.62% ========================================== Files 8 10 +2 Lines 310 362 +52 ========================================== + Hits 309 355 +46 - Misses 1 7 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 86a9695e0578d7fac31b2bed522fd50107988e41 is merged into main:

github-actions[bot] commented 3 weeks ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 9581170494bb3c7d8dd93b91db3326a6c1d54960 is merged into main:

seabbs commented 3 weeks ago

I'm fairly horrified by what I had to do here to get this working but despite that I think its the most sensible approach that retains modularity

github-actions[bot] commented 3 weeks ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 596c03f5db9d7029ffbf088f087970499c7919a3 is merged into main:

seabbs commented 3 weeks ago

Test gaps are due to the current lack of analytical solutions so I think this is good to go.