epiphyt / embed-privacy

Embed Privacy prevents loading of embedded external content and allows your site visitors to opt-in.
https://epiph.yt/en/embed-privacy/
GNU General Public License v2.0
19 stars 12 forks source link

Warning: filemtime(): stat failed for ... /plugins/embed-privacy-dev/inc/class-fields.php #209

Closed oldrup closed 7 months ago

oldrup commented 7 months ago

Bug/Problem

Hey!

Testing the current dev version, I get these two warnings when editing an embed:

Warning: filemtime(): stat failed for /example.net/wp-content/plugins/embed-privacy-dev/assets/js/admin/image-upload.min.js in /home/sustain2/oldrup.dk/wp-content/plugins/embed-privacy-dev/inc/class-fields.php on line 66

 Warning: filemtime(): stat failed for /example.net/wp-content/plugins/embed-privacy-dev/assets/style/embed-privacy-admin.min.css in /home/sustain2/oldrup.dk/wp-content/plugins/embed-privacy-dev/inc/class-fields.php on line 71

Screenshot:

image

Just double-checked - this warning does not occur with the current stable version from WordPress.org

The warnings do not interfere with the functionality it seems; I've tested two embed types in two languages on https://oldrup.dk/en/more-speed-less-tracking-with-embed-privacy/ - works well.

Steps to reproduce

  1. install 1.8.1 dev branch
  2. edit an embed
  3. might want to enable WP_DEBUG, not sure

Version

1.8.1 dev branch

Link

No response

Environment info

No response

Code of Conduct

MatzeKitt commented 7 months ago

You’ve probably missed to build the minified JavaScript/CSS files.

To do so, run the following commands:

npm install
npm run build
oldrup commented 7 months ago

You’ve probably missed to build the minified JavaScript/CSS files.

Yeah, I definitely missed to build anything because I just downloaded the dev zip and uploaded it to my site 😁 Honestly, I had no idea I needed to build anything, sorry about that.

Still, it works fine on the front end, with the 4 types of embeds I tested, on 3 different sites (same host though).

Please let me know if I can help in any other way, and thank you for all your hard work. It's very much appreciated 😍

MatzeKitt commented 7 months ago

Yeah, the readme here on GitHub definitely needs to be adjusted accordingly! Thank you for the heads up. 🙂