epiphyt / form-block

An extensive yet user-friendly form block.
https://formblock.pro/en/
GNU General Public License v2.0
5 stars 0 forks source link

Follow the theme design for the submit button #7

Closed zu closed 1 year ago

zu commented 1 year ago

What feature are you requesting?

The form's submit button should look like the theme design's button style. This doesn't work out of the box and can't be overriden with adding the class "wp-block-button__link" or "wp-element-button" (see screenshot)

2023-04-10-button

Why is this feature necessary?

I think, this should be default behaviour.

Are you expecing side-effects?

no, except that Im hesitant to use the plugin like this

Code of Conduct

MatzeKitt commented 1 year ago

You’re right. I also noticed that during release of version 1.0.0 and definitely will adjust that.

zu commented 1 year ago

btw, if I sound a bit unfriendly, I'm sorry! It wasn't meant like this, but now I feel "being hesitant to use the plugin like this" sounds very harsh which wasn't my intent. I really like how the form works.

Thanks for your quick replay. I tried to work around it with theme.json but couldn't figure it out.

Interestingly the reset button looks different then the submit button (but also not the same as the theme default)

MatzeKitt commented 1 year ago

I didn’t took it negatively, everything’s fine. 🙂

zu commented 1 year ago

https://user-images.githubusercontent.com/147629/231100368-4f919e96-3ee8-4de8-b88b-1cba25fb13f7.mp4

I realized that the label/name of the button doesn't adjust to the input in the Name field and is even submit for the reset button.

MatzeKitt commented 1 year ago

Can you please create a separate issue for that?

zu commented 1 year ago

Sure. Created a new issue: https://github.com/epiphyt/form-block/issues/8