Segmentation Faults and Fixes to Run main branch on macOS

AndrewLitteken commented 5 years ago

Fixes Included:

Changes to CFG.h to work around a more restrictive Xcode toolchain
Main Makefile now uses the environmental variable ENABLE_LIBCPP=1 for macOS Builds since the 32-bit version is now deprecated in macOS Sierra onwards (10.12+)
Fix in llvm/Makefile.rules to fix a bad regex where it would only capture the first digit of the minor version
Fix in llvm/projects/sample/autoconf/config.guess to find the architecture the same way llvm does so the 64-bit libraries are used
Fix in llvm/lib/Transforms/Scaffold/ResourceCount.cpp to actually have the right number of array cells to avoid seg faults upon destruction of object
Fix in llvm/lib/Transforms/Scaffold/ResourceCount.cpp to pass the map by reference rather than copy, avoiding seg faults when looking through the map to find gates
Fix in llvm/tools/bugpoint/ToolRunner.cpp to change errs() << OS; to errs() << OS.str(); as suggested in Issue #37
Changes in scaffold/Scaffold.makefile to find the SDK automatically so regression tests do not fail because header files cannot be found
Changes in scripts/regression_test.sh to find Scaffold.dylib on macOS
Changes in the example test cases so that a lowercase z is used rather than a Z

closes #32 closes #37

AndrewLitteken commented 5 years ago

I wanted to also try to fix the Illegal Instruction: 4 issue that is occurring in RKQC, but I wasn't able to track down why that is happening yet.

AndrewLitteken commented 5 years ago

All the tests should pass on both macOS and Ubuntu now! There was an array indexing issue for the swap_a_to_b function

epiqc / ScaffCC