search

episerver / Quicksilver

EPiServer Commerce MVC Reference Architecture for Commerce 13 (.NET Framework 4.x)
Apache License 2.0
78 stars 97 forks source link

NuGet config for msbuild to find Episerver packages #23

Closed Rinorragi closed 7 years ago

Rinorragi commented 7 years ago

I added NuGet.config into solution folder root. All build environments are not controlled by developers and for that reason solution should give a hint where to download episerver binaries. NuGet.Config is built for that. https://docs.microsoft.com/en-us/nuget/consume-packages/configuring-nuget-behavior

After this change I was able to make VSO builds and Azure Git deployments (both) work. Before this they both crashed on missing Episerver binaries.

Personally I would added a solution folder into visual studio and added file there too but I didn't want to manipulate the solution file.

quanmaiepi commented 7 years ago

Thank you for your contribution. However due to our workflow, we won't merge this, because the changes will be overwritten once we publish newer release of QuickSilver. We'll look into this and include these changes from our side. Again - thank you, and keep it coming!

Rinorragi commented 7 years ago

Is there a reason why could not just add this as a remote in Git and merge these changes back to your development repository?

magnusstrale commented 7 years ago

The files we push to GitHub have been transformed from our development repo, so it's not trivial to merge from GitHub. However this is being worked on so I expect that we will have your contribution on GitHub sometime next week as part of our regular updates.

Thank you for taking the time to help out!

Rinorragi commented 7 years ago

I understand. No problems. I guess if I find something I will still in the future also create pull requests since that is the most convenient way to inform you about problems. Response time was also nice.