search

episerver / Quicksilver

EPiServer Commerce MVC Reference Architecture for Commerce 13 (.NET Framework 4.x)
Apache License 2.0
78 stars 97 forks source link

Change in ServiceInstanceScope for PromotionService/EntryService/HelperFacade throws error when sessionstate is enabled #9

Closed jstemerdink closed 8 years ago

jstemerdink commented 8 years ago

After the change of the ServiceInstanceScope from Singleton to HybridHttpSession on PromotionService/EntryService/HelperFacade (in the development branche), Redis throws an error that these are not marked Serializable.

When marking them Serializable: PromotionHelper in Facade must be marked NonSerialized, as is it not serializable. ReferenceConverter in PromotionService must be marked NonSerialized, as is it not serializable.

mrahl commented 8 years ago

Thanks for reporting, sorry for the late reply. I have logged this bug in our internal repo and we will look into it shortly.

quanmaiepi commented 8 years ago

Hi, It should be fixed by now with latest commit in develop. The life cycle has been changed back to Singleton

mrahl commented 8 years ago

Right you are, I should have checked first. The code is the same in master too.

magnusstrale commented 8 years ago

Closing