episerver / content-search-lucene

Apache License 2.0
1 stars 1 forks source link

Reasoning for content events initialization #24

Open karolberezicki opened 1 year ago

karolberezicki commented 1 year ago

Hi,

The content events are currently initialized in IndexingJobService in the method InitContentEvent after the IndexAllOnce. However, once the application is restarted / redeployed, the content events will be lost unless we'll reindex the whole site again, and for bigger sites it may take couple of hours. I'm wondering if there's any particular reason why the content events are not initialized during the application startup, but rather in the reindexing job?

lunchin commented 1 year ago

Not sure why was done like this. We can try to move to application startup and see if works fine.

karolberezicki commented 1 year ago

I'll try it and create another PR if it proves to be working good.

ellinge commented 1 month ago

We had our luck reverting these changes (init of events in job and indexing directly in job), more details in #29