search

episerver / content-templates

Apache License 2.0
12 stars 7 forks source link

Publish CI packages to GitHub Packages #27

Closed hennys closed 2 years ago

hennys commented 2 years ago

Enable publishing of packages to local Github Packages feed when creating PRs

JohanPetersson commented 2 years ago

While we're at it, should we add license to the package? <license type="expression">Apache-2.0</license>.

tidyui commented 2 years ago

While we're at it, should we add license to the package? <license type="expression">Apache-2.0</license>.

It's a bit tricky. The repository itself should have a clear license (which it has) but the code generated by the templates package with dotnet new should not have a license as it's a template and the output is owned by the person who generated it. So, should the template package itself then have a license?

JohanPetersson commented 2 years ago

While we're at it, should we add license to the package? <license type="expression">Apache-2.0</license>.

It's a bit tricky. The repository itself should have a clear license (which it has) but the code generated by the templates package with dotnet new should not have a license as it's a template and the output is owned by the person who generated it. So, should the template package itself then have a license?

Good question. Other templates, including Microsoft's, has a license though https://www.nuget.org/packages?packagetype=template&sortby=relevance&q=&prerel=True.

We can link to the license file in the repo, instead of using the expression. Not sure what is the preferred way.

tidyui commented 2 years ago

Fair enough! Let's add the license to the package!