search

episerver / content-templates

Apache License 2.0
12 stars 7 forks source link

Net6 #40

Closed JohanPetersson closed 2 years ago

JohanPetersson commented 2 years ago

I recommend doing review commit-by-commit. The commits with a lot of changed files (Re-adds suffix to make project names a bit more clear, Adds file-level namespaces and Adds implicit and global usings) do not contain any code changes other than formatting.

hennys commented 2 years ago

I personally prefer adding global usings to the .csproj file rather than having a code file for it, such as GlobalUsings.cs. Since they are empty anyway, could we not leave the choice of pattern for the users?

JohanPetersson commented 2 years ago

I personally prefer adding global usings to the .csproj file rather than having a code file for it, such as GlobalUsings.cs. Since they are empty anyway, could we not leave the choice of pattern for the users?

I don't have a strong opinion. The only nice thing with having them in a code file, is that you can see if they are used, otherwise they're greyed out. But I'll move them.

hennys commented 2 years ago

I personally prefer adding global usings to the .csproj file rather than having a code file for it, such as GlobalUsings.cs. Since they are empty anyway, could we not leave the choice of pattern for the users?

I don't have a strong opinion. The only nice thing with having them in a code file, is that you can see if they are used, otherwise they're greyed out. But I'll move them.

Maybe that's why the GlobalUsings were empty. Because you had done "remove unused usings" code fix on the solution 😆

JohanPetersson commented 2 years ago

I personally prefer adding global usings to the .csproj file rather than having a code file for it, such as GlobalUsings.cs. Since they are empty anyway, could we not leave the choice of pattern for the users?

I don't have a strong opinion. The only nice thing with having them in a code file, is that you can see if they are used, otherwise they're greyed out. But I'll move them.

Maybe that's why the GlobalUsings were empty. Because you had done "remove unused usings" code fix on the solution 😆

Oh, I didn't notice that. That was probably the case in the empty templates. In Alloy they should have been there at least. Hehe.