search

episerver / upgrade-assistant-extensions

Apache License 2.0
10 stars 6 forks source link

Support net6.0 #36

Closed shahramshahram closed 2 years ago

modulus37 commented 2 years ago

Please do merge it yourself

jbearfoot commented 2 years ago

Are you sure just this changes work? Reason for asking is that I tried to target net6 previously and even though the migration passes without errors, a lot of the code changes are actually never performed (e.g. the built-in one of changing of using statements). When I debugged it looked like it checked among the project dependencies for aspnet.core references, but since EPiServer.CMS was targeting net5 and the tool itself was net6 it compared wrong versions of aspnet core packages so it falsely though it was not a aspnet core project. So I think we should update the EPiServer.CMS package reference in the package map (and others as well to latest) to net6, but that require cms ui in net6. Then try to run the migration on alloy and verify that code changes are applied (like the change of using statements).

shahramshahram commented 2 years ago

Yes, it is my plan to waiting the cms ui be released and after that change the config map for dependencies. Good point I will check the result from upgrading as well as you mentioned I did not get error and only check the project target and it was on net5 or net6 then I assumed everything was ok. I will re test it and wait to UI also.