search

episerver / upgrade-assistant-extensions

Apache License 2.0
10 stars 6 forks source link

PropertyData.ParseToObject #4

Closed lunchin closed 3 years ago

lunchin commented 3 years ago

Method removed no override available. Should remove method if found on subclasses of PropertyData

modulus37 commented 3 years ago

Mark, I was checking this in the code: in the .Net Framwork Foundation Project.

eg. in Features/CatalogContent/DanymicVatiation/DynamicVariant.cs

[Obsolete("ParseToObject is no longer required to be implemented. The same functionality can be achieved by creating a new instance and calling the ParseToSelf method.")] public override PropertyData ParseToObject(string value) { var prop = new VariantGroupPropertyList(); prop.ParseToSelf(value); return prop; }

So you want to have this basically removed if it exists? is ther any replacement for this?

I could not find PropertyData.ParseToObject in any place. would it be possible for you to provide me a mor detailed sample.

eg.

Old version and new version.

Another thing.

lunchin commented 3 years ago

Just remove the method if it exist. Partners often create custom properties in implementations.

modulus37 commented 3 years ago

Method: like ParseToSelf will be removed from the source. this is now implemented.