episphere / connect

Connect API for DCEG's Cohort Study
10 stars 5 forks source link

Update regex for Home mouthwash collection query (Biospecimen) #1118

Open Gbarra9 opened 1 week ago

Gbarra9 commented 1 week ago

This issue is related to issue #1063.

A user added a variation of "P.O. box" that the current regex did not match as true.

Ex. "pobox123"

erincschwartz commented 1 week ago

@Gbarra9 The Biospecimen Team reviewed the list you provided yesterday and we would like the program to flag as 'true' all of the variations listed with the exception of the following, which can remain 'false' and unflagged:

The other cases currently listed as 'false' could occur and we would like to err on the side of ensuring that these do not get pulled into the queue for addresses to be printed.

Can the program be updated to make these changes?

Gbarra9 commented 4 days ago

Reference for testing as a continuation of Home mouthwash collection query changes- Biospecimen (August*)

sonyekere commented 8 hours ago

Ready for Prod