episphere / connect

Connect API for DCEG's Cohort Study
10 stars 5 forks source link

Mouthwash Overhaul Assign Kits (Biospecimen) #1135

Open Davinkjohnson opened 1 month ago

Davinkjohnson commented 1 month ago

(High Priority)

-This has a sequentially executed write process that can cause database inconsistencies where one operation succeeds and another fails. This can lead to hard-to-diagnose bugs and data inconsistencies.

-we should check with Erin and Chris to see what issues have been found here.

amber-emmes commented 1 month ago

Just wanted to double-check... in the current workflow, if the count of participants found isn't exactly 1 (so if no participant is found or if two participants are found) it doesn't update any participant records, and it returns false, but it does still update the kit record. Is that desired behavior or should it change?

sonyekere commented 1 month ago

Looping in @erincschwartz for potential feedback on Amber's question above.

amber-emmes commented 5 days ago

This is in dev and ready to test.