episphere / quest

experimenting with the idea of a questionnaire markup
https://episphere.github.io/quest/
2 stars 11 forks source link

Removing single quotes around displayif not working #387

Closed boyd-mj closed 2 years ago

boyd-mj commented 2 years ago

@danielruss we have tested this (removing quotes around displayif statements that includes an "and" and thus spacing) and the displayifs are not functioning as expected in either the main renderer or your personal renderer. I will have someone post additional details as soon as possible, but wanted to alert you since this is related to finishing Module 4.

@guinevere83 or @huip-ims please add details for Daniel

guinevere83 commented 2 years ago

Sure. Seems like the changes for summary screens are showing 2nd Address, 3rd Address etc. regardless of if there were NR values for those addresses. Previously, they wouldn't display:

image

For the childhood address summary, it's causing stray code to show up like so:

image

danielruss commented 2 years ago

ok. This is in module 4?

huip-ims commented 2 years ago

Daniel, you're correct. It's in module 4.

danielruss commented 2 years ago

pushed a fix.

boyd-mj commented 2 years ago

@guinevere83 please retest this section

guinevere83 commented 2 years ago

image

This looks to be resolved. Thanks!