search

episphere / quest

experimenting with the idea of a questionnaire markup
https://episphere.github.io/quest/
2 stars 11 forks source link

Inconsistent variable names created within loops #390

Closed huip-ims closed 2 years ago

huip-ims commented 2 years ago

@danielruss @boyd-mj @huip-ims Hi Daniel – We are seeing some inconsistent variable names created by quest within loops and are hoping you can help us understand why this is happening.

In the biospecimen survey, there is a COVID-19 loop. During each iteration of the loop, some Quest IDs are used to create variable names with “_1”, “_2”, “_3”, & etc. However, other Quests IDs within the same loop are used to create variable names with “_1_1”, “_2_2”, “_3_3”, & etc. Do you know why “_1_1” would be used in some situations rather than “_1”? See examples in screenshot below.

image

danielruss commented 2 years ago

@huip-ims This was an old mistake that I never saw the value in fixing. Here is the history:

The idea was that the first _1 was the "loop number" in other words the first loop in the module would be _1 the second loop in the module would be _2 , etc. The second underscore would be the "loop count index" i.e. the first iteration of the loop would be _1, the second iteration would be _2. This would guarentee all loop question ids would be unique. XXX_1_2 would be the second iteration of the first loop.

As it turns out, this was 1) unnecessary -- all question id's are unique so there are no duplicated id between loops ergo no need to have a loop number 2) incorrectly implemented -- it's always _1_1, _2_2 ...

danielruss commented 2 years ago

I think you see _1 sometimes and _1_1 at other times because the question ids are getting the _1_1, and |__|id=xxx| becomes xxx_1, xxx_2.

As I said, this is an implementation flaw, but it works. We could fix it at the risk of breaking it. Hence, I never saw the value in fixing it. We are hoping to fix this in the future. (However, we need to loop in Nichole because it WILL have an effect on connect.

boyd-mj commented 2 years ago

Hi Daniel,

Thanks for the explanation. No need to go any further at the moment. We need to check on how this might affect the transformer and then we can go from there.

Jen

From: danielruss @.> Sent: Wednesday, April 20, 2022 11:12:57 AM To: episphere/quest @.> Cc: Boyd-Morin, Jennifer (IMS) @.>; Mention @.> Subject: Re: [episphere/quest] Inconsistent variable names created within loops (Issue #390)

I think you see _1 sometimes and _1_1 at other times because the question ids are getting the _1_1, and |__|id=xxx| becomes xxx_1, xxx_2.

As I said, this is an implementation flaw, but it works. We could fix it at the risk of breaking it. Hence, I never saw the value in fixing it. We are hoping to fix this in the future. (However, we need to loop in Nichole because it WILL have an effect on connect.

— Reply to this email directly, view it on GitHubhttps://github.com/episphere/quest/issues/390#issuecomment-1104049762, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATJL76U6W6IMR5YGYHSTTPLVGANHTANCNFSM5T2WOVYA. You are receiving this because you were mentioned.Message ID: @.***>

Information in this e-mail may be confidential. It is intended only for the addressee(s) identified above. If you are not the addressee(s), or an employee or agent of the addressee(s), please note that any dissemination, distribution, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender of the error.

boyd-mj commented 2 years ago

No changes requested. If this changes with Quest 2.0, please let us know so we can make adjustments to the transformer software as needed. Thanks!