search

episphere / quest

experimenting with the idea of a questionnaire markup
https://episphere.github.io/quest/
2 stars 11 forks source link

CID 112151599 Saving as both integer and string #406

Closed FrogGirl1123 closed 2 years ago

FrogGirl1123 commented 2 years ago

CID 112151599, "Have you had a menstrual period in the last 60 days?" saves replies as a mix of integers and strings. Both Yes and No, as all response CIDs, need to be saved as integers. When two formats are used it causes structural issues on the back end.

danielruss commented 2 years ago

@naiyume I don't believe this is a quest issue. Quest saves both true and false as strings. Can you check the PWA "write results to firebase" code.

FrogGirl1123 commented 2 years ago

Connect ID 6748294551 is an example of the integer and Connect ID 6697891999 is an example of the string.

anthonypetersen commented 2 years ago

@FrogGirl1123 looking at the database this feels like a case of someone manually making that value an integer.. I see 10 other participants that have "yes" for that question and they are all saved in string format.

Daniel is correct though, Quest is saving everything as strings.

FrogGirl1123 commented 2 years ago

@anthonypetersen and @danielruss that would explain why it's a unique case. I guess we can close this. Once we clear dev it shouldn't be an issue anymore. @danielruss can the Quest or the PWA for that matter save responses as integers? It would be nice if at some point (maybe it will have to be in BQ2) we could have all the CID responses in the survey data as integers to match the rest of the Connect data.

danielruss commented 2 years ago

@FrogGirl1123 hmmm... possibly.. String are nice because they are generic. You would force me to have to figure out whether something whether something should be a number or string. |__|__| , () or [].

Of course you have the data dictionary, you can look it up and convert the string to number.

How important is it that I store the value as a number?