episphere / quest

experimenting with the idea of a questionnaire markup
https://episphere.github.io/quest/
2 stars 11 forks source link

in-survey accessibility enhancements #436

Closed JoeArmani closed 4 months ago

JoeArmani commented 4 months ago

Hi @danielruss @anthonypetersen, please review this when you have a chance. Thank you.

PR: JAWS / Accessibility enhancements Related: https://github.com/episphere/connect/issues/931

• Accessibility enhancements for easier screen reader use. • Update grid to table (screen reader friendly), increase click target size. • Update grid handlers for new table format. • Add checkmark graphic to grid. • Add card layout to mobile grid. • Add aria properties to some inputs. • Autofocus ‘other’ and ‘please describe’ text boxes on click. • Autoclick ‘other’ and ‘please describe’ text boxes on text input. • Update modal for accessible navigation. • Refactor stopSubmit.

TODO: <br> tags need to be handled in some browsers — they read “empty group” which can be confusing with a screen reader.

Example: updated grid view with larger click targets

Screenshot 2024-05-13 at 9 38 16 AM
danielruss commented 4 months ago

please center the check in the box.

image
JoeArmani commented 4 months ago

please center the check in the box.

Updated screenshots: Here are updated versions of the two views, hopefully closer to what you're looking for. • Bigger tap target on desktop - helpful for people with low vision or trouble with fine motor skills. • 4th row shows hover action -- triggered and clickable by hovering over the surrounding label for easier user targeting. • Mobile view converted back to text tap targets.

Questions: Desktop: Do you want this in a separate Connect-specific stylesheet or do you want this available for all users? We can resize the radio buttons if you want them smaller or larger and you want them available for all.

Mobile: Do you have a preference on all caps as before vs standard casing?

Screenshot 2024-05-14 at 11 03 51 AM Screenshot 2024-05-14 at 11 04 47 AM
anthonypetersen commented 4 months ago

Those updated radio buttons look great in my opinion. The size feels appropriate to the area that it's filling.

On the subject of caps, there is an issue active right now (https://github.com/episphere/connect/issues/926) that is asking for us to not put text in all caps as it's harder to read.

JoeArmani commented 4 months ago

Those updated radio buttons look great in my opinion. The size feels appropriate to the area that it's filling.

On the subject of caps, there is an issue active right now (episphere/connect#926) that is asking for us to not put text in all caps as it's harder to read.

Great. I like this version of radio buttons better than the checkmarks and they're way easier to use than the small radios. Agreed about lowercased text. Thanks for pointing out that issue, I'll leave it lowercased.

I increased the specificity of the new table grids. Now the old CSS for quest-grid and the new CSS for quest-grid.table-layout are both supported. This is important since replace2.js references the GitHub repo for those stylesheets... So the old version in production and the new version in testing should be good to go.

JoeArmani commented 4 months ago

Those updated radio buttons look great in my opinion. The size feels appropriate to the area that it's filling.

On the subject of caps, there is an issue active right now (episphere/connect#926) that is asking for us to not put text in all caps as it's harder to read.

@anthonypetersen This round of changes is in and ready for review. Thanks