search

episphere / quest

experimenting with the idea of a questionnaire markup
https://episphere.github.io/quest/
2 stars 11 forks source link

issue #448 fix #449

Closed danielruss closed 4 months ago

danielruss commented 4 months ago

Fix Null pointer error in modal. And bootstrap 4/5 issue closing Modal.

anthonypetersen commented 4 months ago

@danielruss I already have a fix going in for this with my current PR

anthonypetersen commented 4 months ago

@JoeArmani @danielruss more of an FYI but comment if I'm wrong... with these modals I don't think we want to have data-dismiss and data-bs-dismiss both in the attributes section, it's not best practice from what I understand since we aren't falling back to BS4

danielruss commented 4 months ago

The spanish implementation PR?

danielruss commented 4 months ago

I think the PWA uses BS4.3.1. Also, not in the attributes, in the element dataset.

anthonypetersen commented 4 months ago

The spanish implementation PR?

yes - good point on the PWA comment though, I'll add back in the BS4 element