episphere / questionnaire

1 stars 2 forks source link

Text box option does not get stored if only text is entered without selecting radio button #242

Closed joshid-ims closed 11 months ago

joshid-ims commented 11 months ago

Found while testing https://github.com/episphere/questionnaire/issues/240.

Saw this in COV28 and COV19C6A and COV28. Options 1 and 55, respectively, do not get stored in the Question ID if only text is entered in the text box without selecting the radio button for the option. The text gets stored in the corresponding variable though.

Is this a Quest issue?

Davinkjohnson commented 11 months ago

@joshid-ims isn't this basically the same issue as Julie describes in the 2nd comment on https://github.com/episphere/questionnaire/issues/240 ??

joshid-ims commented 11 months ago

These were not text boxes in multi-choice questions. And I tried using the code Daniel suggested. But I will take a look again.

joshid-ims commented 11 months ago

One effect of this is that when we select a value that isn't Other and then enter a value into the textbox, it displays both values, in spite of them being radio buttons. This is because the radio button option does not get saved but the text does along with value other than Other selected first. It does not get overwritten by Other option value.

I think this is a Quest issue, right?

joshid-ims commented 11 months ago

@danielruss and @cusackjm we have tested other issues internally and waiting for this.

cusackjm commented 11 months ago

@danielruss could you review Deepti's question/comments above?

danielruss commented 11 months ago

@cusackjm looking into it...

danielruss commented 11 months ago

@joshid-ims @cusackjm

when we select a value that isn't Other and then enter a value into the textbox, it displays both values, in spite of them being radio buttons.

That should not happen. I was able reproduced your error. This is a quest issue. Closing this issue and opening a quest issue.

danielruss commented 11 months ago

@cusackjm @joshid-ims Update is online, but not yet released. You can use the dev tool to test. If it looks good, I'll release.

boyd-mj commented 11 months ago

@cusackjm @joshid-ims Update is online, but not yet released. You can use the dev tool to test. If it looks good, I'll release.

Hi @cusackjm is this something you can test in dev? I believe there's a question in the updated M2 that we recently delivered that you could use to test.

We need this confirmed fixed and released in order to complete our testing of the COVID-19 survey. Thanks!

cusackjm commented 11 months ago

@boyd-mj I'm still working on the testing spreadsheets for Module 2, but think I will be able to test this too tomorrow

boyd-mj commented 11 months ago

Great, thanks!

cusackjm commented 11 months ago

confirmed fix in module 2

huip-ims commented 11 months ago

@danielruss Daniel - has this fix been released? When I just tested this in the renderer by adding the text in the text box without selecting the radio button, the text is stored correctly, but '55' is stored for the radio button Other option.

huip-ims commented 11 months ago

@danielruss Nevermind, the renderer seems to be working correctly now.

guinevere83 commented 11 months ago

This has passed internal testing and will be delivered soon.

cusackjm commented 11 months ago

confirmed fixed in dev testing 7/24/2023