episphere / questionnaire

1 stars 2 forks source link

Remove extra space between INTROSE [SECTION4] title and intro text #258

Closed cusackjm closed 6 months ago

cusackjm commented 11 months ago

image

SAME AS: https://github.com/episphere/questionnaire/issues/245

cusackjm commented 7 months ago

will this be in the delivery for the Jan prod push? if so, do you have an eta for this?

(I will be OOO 12/4-12/15 and Aileen is taking over testing)

cusackjm commented 6 months ago

Passed dev testing using Chrome, PC on 12/28/2023 Template: https://nih.app.box.com/file/1401074464603

cusackjm commented 6 months ago

In removing the 2 empty lines for INTROSE [SECTION4], did you also remove the single empty lines after all other headings? @boyd-mj @joshid-ims

I compared the spacing in version 1.4 and version 1.5 for the following: INTROSMO [SECTION1], TOBACCO, CIG1, ECIG1, CIGAR1, CHEW1, HOOKAH1, PIPE1, CURRSM, INTROMAR [SECTION2], SMMAR1, TOMAR1, ELMAR1, EAMAR1, THMAR1, INTROALC [SECTION3], BEER1, LIQUOR1, WIN1, OTHALC1, and INTROSE [SECTION4], and the text looks very smooshed without the spacing in between the lines of text.

Can you revert back to version 1.4 for all of the variables above, except INTROSE [SECTION4], which had 2 empty lines in Version 1.4 and should only have 1 empty line.

I've included screenshots that compare the 2 versions here: https://nih.app.box.com/file/1401264750993. Let me know if you have any questions

cusackjm commented 6 months ago

Confirmed fix in dev testing using chrome, laptop on 1/5/2024