episphere / questionnaire

1 stars 2 forks source link

Make all range checks with "age", have 1 added #284

Closed cusackjm closed 7 months ago

cusackjm commented 10 months ago

The following document includes the range checks that just involve "age" and need to be revised to the "age+1" range check: https://nih.app.box.com/file/1294189386644

Qx Subcommittee made decision on 8/30/2023 to make age-based range checks consistent (currently some are based on age and some based on age+1 year)

cusackjm commented 9 months ago

Need to update the DD, will update this issue once the "Notes" range check and variable suffix (_v1r0 to _v1r1) are updated

joshid-ims commented 8 months ago

Only few Year ranges are updated? Is that intentional?

cusackjm commented 8 months ago

yes, not all of the year ranges were missing the 1 year buffer from the range check. we want to be consistent and have all range checks include the 1 year buffer

joshid-ims commented 8 months ago

Ok, thanks.

joshid-ims commented 8 months ago

For First blood transfusion year, the max is Current year. That cannot be changed. Is that right?

cusackjm commented 8 months ago

yes

joshid-ims commented 8 months ago

I think that applied to all Year max limits. Should min be changed?

cusackjm commented 7 months ago

confirmed fix in dev testing on 11/15/2023