episphere / questionnaire

1 stars 2 forks source link

Family history of Dx minimum year calculation needs to be updated (Participant issue) #292

Closed cusackjm closed 7 months ago

cusackjm commented 8 months ago

Participant (CID 4902908009) is seeing incorrect range check for MOMCANC3Q (CID 261863326) The correct answer is [omitted for github, but before 1981]. The survey won't accept that answer and says it has to be 1981 or later.

I was unable to replicate issue [CS0014123], as Module 1 data was only saved up until MHGROUP7 (CID: 874709643).

Is this a PWA or QUEST issue?

Could the incorrect range check be because of previous responses/data not saving? Still unsure where the range check value came from, since there were not any previous responses that would produce that range check value.

danielruss commented 8 months ago

@cusackjm let move this discussion to teams. I will summarize the resolution for archival purposes if possible.

danielruss commented 8 months ago

The problem is the calculation of the earliest possible birth year for the mother.

minval=difference(difference(#currentYear,isDefined(D_378988419,isDefined(D_807765962,125))),1)

if D_378988419 (moms age) is not defined then it uses D_807765962 (age at death). So if the mom died awhile ago, we may underestimating the minimum year that she could be diagnosed.

anthonypetersen commented 8 months ago

The problem is the calculation of the earliest possible birth year for the mother.

minval=difference(difference(#currentYear,isDefined(D_378988419,isDefined(D_807765962,125))),1)

if D_378988419 (moms age) is not defined then it uses D_807765962 (age at death). So if the mom died awhile ago, we may underestimating the minimum year that she could be diagnosed.

So is this an issue with the logic of the module?

cusackjm commented 8 months ago

yes @anthonypetersen

brotzmanmj commented 8 months ago

Thanks. Who is moving this to the next step to fix this and what is the time frame for the fix? Are any other questions affected or just this one?

cusackjm commented 8 months ago

Daniel has proposed range check edits and they are on the agenda for the 10/25 Questionnaire Subcommittee Meeting. Outlined in slides 2-4: https://nih.app.box.com/file/1337113211715 I can send this via email if you think we should review them before that meeting.

Only the Year of Dx is impacted for the Family History of Cancer (i.e., mom, dad, siblings, and children) because we have to calculate their age without knowing their birth year

cusackjm commented 8 months ago

(moving this to questionnaire repository)

cusackjm commented 8 months ago

@boyd-mj @joshid-ims to avoid any calculation issues, the Questionnaire Subcommittee would like to change the range check minimum year from a calculation to set minimum value of 1800.

This edit only applies to the year of diagnosis range check minimum (no change to the maximum range check; no change to the age of diagnosis range check), for MOMCANC3A-MOMCANC3W, DADCANC3A-DADCANC3V, SIBCANC3A-SIBCANC3Y, CHILDCANC3A-CHILDCANC3Y

danielruss commented 7 months ago

@cusackjm what is the status of this? ok to close or remove me from the assignment list?

cusackjm commented 7 months ago

@danielruss IMS is working on programming the fix I will remove you from the assignment list

cusackjm commented 7 months ago

confirmed fixed in dev testing on 11/15/2023