search

episphere / questionnaire

1 stars 2 forks source link

Grid display in Dev - No boxes around responses and text in center, not left orientation #302

Closed cusackjm closed 6 months ago

cusackjm commented 7 months ago

Testing Blood/Urine Survey (clinical collection) in Dev and am seeing this: image

@danielruss assuming this is related to the grid fixes (#299)? Going to test in stage to see if the display changes.

joshid-ims commented 7 months ago

I am not sure if it is related to https://github.com/episphere/questionnaire/issues/299.

danielruss commented 7 months ago

@cusackjm fix pushed please check.

cusackjm commented 7 months ago

The multiple choice responses are centered too (Module 1, Dev) @danielruss image

danielruss commented 7 months ago

Sorry, I don;t understand. They are not centered. Also, where they always that big?

danielruss commented 7 months ago

Do you still see the text not centered?

image
danielruss commented 7 months ago

OH WAIT are the suppose to be on the left????

danielruss commented 7 months ago

@cusackjm now left justified.

cusackjm commented 7 months ago

@danielruss theyre on the left, but is it possible to have them indented slightly like before? :) image image

danielruss commented 7 months ago

Can you do a quick test. I think you may have beat me to all my changes.

image
cusackjm commented 7 months ago

it still looks the same in dev

danielruss commented 7 months ago

are you looking at the pwa?

cusackjm commented 7 months ago

yes, should i look in the renderer instead?

cusackjm commented 7 months ago

@danielruss @anthonypetersen do you have an eta on this?

danielruss commented 7 months ago

@cusackjm The dev tool is no longer centered and has a border (admittedly the same color as the background). I assume you mean the PWA. I'll release the latest version of quest and you should see the updates.

cusackjm commented 7 months ago

@danielruss Testing BUM in Stage, using Safari and iPad: the MED1 questions are formatted as a Grid. image

On a laptop, they are formatted as multiple choice questions. Is this related to this issue?

danielruss commented 7 months ago

No, this has to do with the size of the screen. A small screen uses the multiple choice, a larger screen uses the grid. This is a feature, not a bug.

cusackjm commented 7 months ago

@danielruss can you go back to the previous feature, where all grid questions are forced to the sub-question type? I.e., force to multiple choice or select all that apply?

cusackjm commented 7 months ago

@danielruss since reverting quest yesterday, the grid questions are back to being forced to the sub-question type (tested in Covid Survey, Stage, Safari, iPad), but the response text is still formatted to the center

cunnaneaq commented 6 months ago

B/U survey - Dev, Macbook, Chrome and Dev, iPad, Safari

Seeing the grid, I think we want the forced sub-question type

Screenshot 2023-12-15 at 5 11 09 PM

image

cusackjm commented 6 months ago

image @danielruss grids don't have the radio buttons anymore, but are back to missing grid lines and text is centered Tested in Dev, Chrome, PC

cusackjm commented 6 months ago

@danielruss should I create a separate issue to track the response text orientation? Not sure if the response orientation fix was pushed image

danielruss commented 6 months ago

Is this still a problem?

cusackjm commented 6 months ago

@danielruss should I create a separate issue to track the response text orientation? Not sure if the response orientation fix was pushed image

@danielruss the response text in the check box was fixed. Closing this and re-opening a new issue (#314) to address the response text for radio buttons to avoid confusion