episphere / questionnaire

1 stars 2 forks source link

"Current Address" in Module 4 Spanish version #334

Open joshid-ims opened 3 months ago

joshid-ims commented 3 months ago

Words "Current Address" were inserted in all summary questions in case user does not enter any address details. Like:

image

We need to know what to insert in the Spanish version for that.

cusackjm commented 3 months ago

"Current Address" was translated to "Dirección actual" in the Questionnaire Document. Could you indicate where it needs to be added (to replace "current address")? @joshid-ims

joshid-ims commented 3 months ago

Yes, found in some places. I can use that in other places where it is inserted if user does not enter any details of the address. I have highlighted some such places in the document here. Let me know if that is ok. NIH-23-200 #9850_NCI_Baseline Quex Module 4_Version 1.4_05242021_Spanish.docx

joshid-ims commented 3 months ago

Apart from this, there are words like "1st Address", "2nd Address", etc. inserted in many places again for the same reason, if user does not give any details of the address. What to insert there? There are many places like that with only () added in the document.

cusackjm commented 3 months ago

@joshid-ims I will take a look. This may have to go back to the translator, I'll keep you posted when I know more

joshid-ims commented 3 months ago

Sounds good. Thanks!

cusackjm commented 3 months ago

@joshid-ims I'm in the process of adding the text in to the IMS document

cusackjm commented 3 months ago

@joshid-ims I added the piped text instructions for most of the HOMEADD section, as an example for how the directions should be added back in. Let me know when the rest of the skip logic directions are added and I will review them

joshid-ims commented 3 months ago

Ok, thanks!

joshid-ims commented 3 months ago

Is it ok to use

¿En qué año se mudó a la dirección actual que nos dio [insert address from HOMEADD1_1 – HOMEADD3_1/]?

instead of:

  1. [HOMEMOVEIN1] ¿En qué año se mudó a [insert address from HOMEADD1_1 – HOMEADD3_1/la dirección actual que nos dio]?

as this will need some additional coding to add highlighted text if address details are not provided?

cusackjm commented 3 months ago

@m-j-horner, can you see Deepti's comment above? This translates to the same thing, and would simplify coding, but I am not sure how much we can deviate from the IRB? The text is not different, just the placement of the text in the sentence

joshid-ims commented 3 months ago

Actually, this is the case for may other questions like HOMEWTR1_1, etc.

joshid-ims commented 3 months ago

(0) Water from the tap or refrigerator that has not been |popup|filtered or treated|Informational Text|Please only include water that has not been filtered or treated through reverse osmosis, distillation, or filters that remove lead, chlorine, pesticides, or other chemicals. You can include water filtered with water softeners, which are filters that remove only sediment from the water.|

The popup in this is not present in the translation.

Agua de la llave (grifo) o del refrigerador que no se haya filtrado o potabilizado

cusackjm commented 3 months ago

@joshid-ims could you provide the variable name where it is missing? and where did the translation you provided come from?

joshid-ims commented 3 months ago

HOMEWTR3_1

cusackjm commented 3 months ago

@joshid-ims I accidentally deleted it, but rejected the tracked changes, so the statement is back

joshid-ims commented 3 months ago

Ok, thanks

joshid-ims commented 3 months ago

I do not see it.

cusackjm commented 3 months ago

image image

This matches the English version, but it looks like the information on where this goes is lacking, and it is not written for each address. @joshid-ims do you want me to add additional specs for where it goes (I think it's highlighted text for HOMEWTR3_2= 0 response), and repeat it for each HOMEWTR3 question? Alternatively, we could provide this as a "NOTE TO PROGRAMMERS" at the top of this section, so we don't have to repeat it at each question. Let me know what you prefer, and I will apply it to both the English and Spanish questionnaire documents

joshid-ims commented 3 months ago

Some of the words that need to be translated:

1st Address Your childhood home

I will add to the list if I find more.

joshid-ims commented 3 months ago

this need to have a separate variable.

Desplazamiento al trabajo antes de la pandemia de COVID-19

cusackjm commented 3 months ago

@joshid-ims could you denote the variable so I can check where this occurs

joshid-ims commented 3 months ago

1st Address: SEASADD4_1, SEASADDSUM_1, all summaries of seasonal addresses, SEASADDYRS1_1, 2_1, SEASADDMOS1, SEASWTR1_1, SEASWTR3_1

Your Childhood home: CHILDADD4,5,6, CHILDWTR1, 2

joshid-ims commented 3 months ago

CURWORKCONFIRM - Current address

joshid-ims commented 3 months ago

For CURWORKYR1: In what month and year did you start commuting to translates to : ¿En qué mes y año empezó a desplazarse?

we have in document: ¿En qué mes y año empezó a desplazarse a

which translates to: In what month and year did you start moving to

Is that right?

joshid-ims commented 3 months ago

The pop up text in this question is not in the document.

[CHILDADD6?] What year did you |popup|move out|Informational Text|If you moved from this home to go to college and did not live here again for more than 6 months at a time, enter the year that you went to college.| of

cusackjm commented 3 months ago

@joshid-ims hi- i am going to add all of the missing text tomorrow

joshid-ims commented 3 months ago

Sounds good. Thanks!

cusackjm commented 3 months ago

@joshid-ims qx documents should all be in sync :) Let me know if you have any questions

joshid-ims commented 3 months ago

Ok, I will take a look. Thanks!

joshid-ims commented 3 months ago

Now the only difference is, instead of "2nd Address you provided" we only have "2nd Address" in current code. Please add it in next Module 4 changes if you want to have that.

Will you be updating Spanish version for the missing words I mentioned in previous comments?

cusackjm commented 3 months ago

@joshid-ims could you provide the variable name?

joshid-ims commented 3 months ago

For 2nd Address?

joshid-ims commented 3 months ago

HOMEADD4_2, HOMEADDSUM_2, all such summary questions, HOMEMOVEIN2, HOMEMOVEOUT2, HOMEWTR1_2, 3_2, etc., SEASADD4_2, all seasonal address summaries, SEASADDYRS1_2, SEASADDYRS2_2, SEASADDMOS_2, SEASWTR1_2, 3_2, 4_2, etc.

cusackjm commented 3 months ago

So the markdown in prod has "2nd address" but English and Spanish questionnaire docs have "2nd address you provided"'?

joshid-ims commented 3 months ago

Yes English doc has "2nd address you provided"'.

Spanish one (when I translate) has 2nd address in some places but "la 2ª dirección que nos dio" in some places which translates to "the 2nd address he gave us" (not confident if it is wrong/right - this is from Google).

cusackjm commented 3 months ago

That's fine, we have to follow what the translator provided

joshid-ims commented 3 months ago

So can I continue coding Spanish version?

cusackjm commented 3 months ago

yes

joshid-ims commented 3 months ago

ok, thanks!

joshid-ims commented 3 months ago

Grid name "Typical workday" (CURWORKT2) does not have corresponding name in Spanish version.

cusackjm commented 3 months ago

Could you send screenshots of the discrepancies? I don't see what you mean

joshid-ims commented 3 months ago

In English code:

grid? id="GRID_CURWORKT2" Typical WORKDAY [ [CURWORKT2A,displayif=equals(CURWORKT1,0)] Car, van, or truck (includes carpools or van pools); [CURWORKT2B,displayif=equals(CURWORKT1,1)] Taxicab (includes, Uber, Lyft, or hired car); [CURWORKT2C,displayif=equals(CURWORKT1,2)] Motorcycle; [CURWORKT2D,displayif=equals(CURWORKT1,3)] Bus or streetcar/trolley, light rail/trolley; [CURWORKT2E,displayif=equals(CURWORKT1,4)] Commuter rail, subway, metro; [CURWORKT2F,displayif=equals(CURWORKT1,5)] Bicycle; [CURWORKT2G,displayif=equals(CURWORKT1,6)] Walking; [CURWORKT2H,displayif=equals(CURWORKT1,55)] Other;] //This should show the text typed in for Other but that is not currently supported

(0:15 minutes or less) (1:16 to 30 minutes) (2:31 to 59 minutes) (3:1 hour) (4:2 hours or more) |

Document: image

So it is not in English version too.

image

cusackjm commented 3 months ago

@joshid-ims I'm still confused what the issue is?

joshid-ims commented 3 months ago

Words "Typical Workday" are not in English and Spanish Word documents. It is name of the grid (on top of the grid) which is in code. We need it translated to Spanish if we have to add it there. It needs to be added in English doc also.

cusackjm commented 3 months ago

Please remove it from the English markdown. We cannot alter the Spanish content.

joshid-ims commented 3 months ago

Daniel will be able to tell but I think we need some text there. I tried it in renderer and it does not work without text there.

joshid-ims commented 2 months ago

Keeping this one on hold. Not continuing to code.

cusackjm commented 1 month ago

@joshid-ims I updated the English questionnaire documents for CURWORK and PREWORK grids to have "Typical WORKDAY". For the Spanish questionnaire documents, CURWORK and PREWORK grids have "Un día laborable habitual"

joshid-ims commented 1 month ago

Thanks!

From: Julie Cusack @.> Sent: Wednesday, May 1, 2024 4:12 PM To: episphere/questionnaire @.> Cc: Joshi, Deepti (IMS) @.>; Mention @.> Subject: [EXTERNAL] Re: [episphere/questionnaire] "Current Address" in Module 4 Spanish version (Issue #334)

@joshid-imshttps://github.com/joshid-ims I updated the English questionnaire documents for CURWORK and PREWORK grids to have "Typical WORKDAY". For the Spanish questionnaire documents, CURWORK and PREWORK grids have "Un día laborable habitual"

— Reply to this email directly, view it on GitHubhttps://github.com/episphere/questionnaire/issues/334#issuecomment-2089060467, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APPZ4422KXL4F4CL3TQCWBDZAFEBXAVCNFSM6AAAAABEUUSFXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBZGA3DANBWG4. You are receiving this because you were mentioned.Message ID: @.***> External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.


Information in this e-mail may be confidential. It is intended only for the addressee(s) identified above. If you are not the addressee(s), or an employee or agent of the addressee(s), please note that any dissemination, distribution, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender of the error.