episphere / questionnaire

1 stars 2 forks source link

Character Limit Not Being Implemented Where Needed #347

Open KELSEYDOWLING7 opened 2 months ago

KELSEYDOWLING7 commented 2 months ago

In looking at the address responses for Module 4 for Geocoding, we noticed that there's a decently high proportion of people responding with both street number and street name in the street number address prompts. We noticed that the markup here does not match the data dictionary; the markup allows up to 99999 characters whereas the Data Dictionary limits it to 6.

[D_121490150?] What is the full street address of the place where you live now? Street number |__|id=D_255248624 min=0 max=999999| Full Street name |__|id=D_945532934| Apartment, suite, unit, building, etc. |__|id=D_469838242| City |__|id=D_303500597| State/Province |__|id=D_195068098| Zip code |__|id=D_202784871| Country |__|id=D_831127170|

image

In issue #227 Tony mentioned the need for minlen / maxlen to properly limit the number of characters participants can put into these types of text prompts where we might possibly expect a combination of number and letter (houses like 12 or condos/apartments like 12B). This should be applied to every address street number, including work places.

We may need to revisit the minlen/maxlen as opposed to min/max for all text boxes where a character limit is set but not enforced as well. We have the character limits in the Module QC, so once that's implemented on the module data we can find these other instances. Unless anyone can think of any important ones offhand

KELSEYDOWLING7 commented 2 weeks ago

Bringing this issue to the top of everyone's inboxes to discuss on today's call