episphere / questionnaire

1 stars 2 forks source link

Incorrect Skip Patterns/DisplayIf #366

Closed woodruffr closed 4 months ago

woodruffr commented 5 months ago

These issues displayed or did not display erroneously. These involve Mark-up changes and don't require any NCI input. This issue is to document the changes so we can confirm when they are fixed.

image

woodruffr commented 5 months ago

The updated Mark-up for this was delivered this morning.

cusackjm commented 5 months ago

can you provide the scenario and responses listed? This may not be an issue

woodruffr commented 5 months ago

The screenshot in the top comment in this issue is from Scenario 5.

cusackjm commented 5 months ago

Just want to confirm that the delivered markdown reflects this logic:

MULT2 is displayed if MULTIBIRTH= 1, 2, 3 image

If MULTIBIRTH= 0 or NR, the participant should not see MULT2.

In scenario 5, the tester should have skipped (i.e., MULTIBIRTH= NR), and then they should have not seen MULT2 for each sibling. Given that the tester saw MULT2 for each sibling, this issue was created. Just want to confirm that the updated markdown addressed the display issue that was related to MULTIBIRTH= NR

joshid-ims commented 5 months ago

Yes, that is what was tested after changes were made in the code. The NR was not taken into account in the code. I changed the logic to add that. It was just checking if it was not 0. Now code is checking if value is one of 1,2 or 3 and then displaying MULT2.

cusackjm commented 4 months ago

can i close this issue?

guinevere83 commented 4 months ago

Thiis is resolved.