episphere / questionnaire

1 stars 2 forks source link

Example text is different in BLDTRANS3 year textbox #382

Closed cusackjm closed 4 months ago

cusackjm commented 4 months ago

BLDTRANS3 shows: image

All previous "Or(xor)" questions (e.g., MHGROUP follow up questions) look like this: image

Would prefer to see this example format, rather than what is at BLDTRANS3 (it looks like something's broken)

anthonypetersen commented 4 months ago

Does this also happen in English? @cusackjm

anthonypetersen commented 4 months ago

O, si le es más fácil recordar en qué año, anótelo aquí:<br/> |__|__|__|__|xor=BLDTRANS3 id=D_197994844 min=#currentYear-valueOrDefault("D_150344905","age",100)-1 max=#currentYear| Año de la primera transfusión

I think min is supposed to be minvalue like other instances where there is |__|__|__|__|

joshid-ims commented 4 months ago

We also see gray text in English in text boxes in renderer. Is that fixed in PWA?

cusackjm commented 4 months ago

@joshid-ims we are ok with the gray text existing, just not the additional text that is shown in BLDTRANS3

joshid-ims commented 4 months ago

Yes, that part is fixed. We were wondering if gray text should be in Spanish.

cusackjm commented 4 months ago

It is in spanish (see the above screenshot)

joshid-ims commented 4 months ago

But we see it in English in renderer. Is that expected?

anthonypetersen commented 4 months ago

The part that Julie has underlined in red shouldn't be displaying to begin with, if that's the text you are referencing @joshid-ims

joshid-ims commented 4 months ago

No, I am not referencing that. I have fixed code for that extra text. This issue we see only in renderer. In OWA, the gray text is in Spanish.

Like Example is in English, not Spanish Ejemplo.

anthonypetersen commented 4 months ago

Please send a picture @joshid-ims

guinevere83 commented 4 months ago

Here you go:

image

anthonypetersen commented 4 months ago

Ah I see... So that text isn't controlled by the language of the markdown you are testing, it is controlled by Quest itself. It appears you have the language mode in English since the buttons are also in English, so the grey text being in English as well makes sense.

woodruffr commented 4 months ago

Is there any way this is related to the unharmonization we did on Survey Language? Julie has reverted the datadictionary. Will getting a new dd with the language values harmonized fixed this?

anthonypetersen commented 4 months ago

@woodruffr there isn't anything that needs to be fixed - the grey text being in English vs Spanish isn't dependent on the markdown if you're using the development tool, it's controlled by a setting within the tool itself

woodruffr commented 4 months ago

OK. I was just checking because we changed the dd/JSON values that aren't used by the Mark-down but are used by NCI to determine which language is being used. We are working on reverting them. I wasn't sure if that mattered, but if they are being set manually that wouldn't matter.

huip-ims commented 4 months ago

The grey text is in Spanish in our Dev testing, so I think this issue can be closed.