episphere / questionnaire

1 stars 2 forks source link

Data stored on backend when response changed from valid value to 'NR' #388

Closed boyd-mj closed 1 month ago

boyd-mj commented 1 month ago

Hi Tony, this is the issue we discussed on our call today regarding changing to an NR response. Passing on what our tester found. I've also added her to this issue if you have follow-up questions. This was found in Module 1, and was reproducible in both dev and in the renderer.

If you go through to MULTIBIRTH and answer NR the first time, the behavior for MULT2 is correct. If after that, you go back and fill in a response for MULTIBIRTH, then the behavior for MULT2 will match what was filled in. All that is good so far, but if you go back and reset the answer and answer NR, the behavior for MULT2 will match whatever the last response is. It looks like the backend doesn't clear out the previous response until a new response is added, so if NR is used, it'll use the old value. I'll show some screenshots to explain:

image

image

anthonypetersen commented 1 month ago

@boyd-mj thank you for the details - I'll take a look and let you know what I find

anthonypetersen commented 1 month ago

@boyd-mj this issue should be resolved now, please confirm on your end before I close out this issue

cusackjm commented 1 month ago

@boyd-mj was this tested?

boyd-mj commented 1 month ago

@anthonypetersen do you know which day the fix was pushed? We saw the issue show up on either the 16th or 17th, but haven't intentionally tested since. If the fix was after that, I will have someone on our team test.

anthonypetersen commented 1 month ago

It looks like code was pushed on the 16th @boyd-mj

boyd-mj commented 1 month ago

@anthonypetersen are you or @cusackjm able to see when Spanish BUM was completed using connect ID 8246497556?

anthonypetersen commented 1 month ago

@boyd-mj 2024-07-16T23:44:20.994Z

boyd-mj commented 1 month ago

@anthonypetersen so that's on the same day your fix was pushed. We saw evidence of it happening in the backend data, but I don't know what time you pushed the fix vs the time above.

Also, we believe we just had this happen in dev testing today with the ALCLIFE grids. The grids appear fine if you go through the scenario properly, but if you enter an age, go back and change it and then proceed you don't see the ALCLIFE2A or ALCLIDE4A. @guinevere83 can give you specifics on how she reproduced this if needed. Note that we could reproduce this in the PWA, but not in the renderer.

guinevere83 commented 1 month ago

I actually saw it in the renderer too. The data looks correct on the backend and I haven't seen issues in non-grid questions, but if I go through the alcohol questions, answer 19 for ALCLIFE4, go to the grid, go back to ALCLIFE4 and put 14, then go back to the grid, it'll display the lower age range as if I still answered 19. Here's a screenshot of what I'm seeing on the backend:

image

Hopefully that's legible but the REGALCOHOL_AGE variable is showing correctly as 14 and the piped text at the top is pulling the variable correctly:

image

It just seems like the grid itself is not getting the update somehow. Let me know if you need any more information.

boyd-mj commented 1 month ago

Thank you for sending this and clarifying!

From: guinevere83 @.> Sent: Tuesday, July 23, 2024 4:58 PM To: episphere/questionnaire @.> Cc: Boyd-Morin, Jennifer (IMS) @.>; Mention @.> Subject: [EXTERNAL] Re: [episphere/questionnaire] Data stored on backend when response changed from valid value to 'NR' (Issue #388)

I actually saw it in the renderer too. The data looks correct on the backend and I haven't seen issues in non-grid questions, but if I go through the alcohol questions, answer 19 for ALCLIFE4, go to the grid, go back to ALCLIFE14 and put 14, then go back to the grid, it'll display the lower age range as if I still answered 19. Here's a screenshot of what I'm seeing on the backend:

image.png (view on web)https://github.com/user-attachments/assets/ff06fadd-0b69-44bd-8946-6d28cb16dc54

Hopefully that's legible but the REGALCOHOL_AGE variable is showing correctly as 14 and the piped text at the top is pulling the variable correctly:

image.png (view on web)https://github.com/user-attachments/assets/f796e628-5b98-4105-a1ed-5a5934d794a3

It just seems like the grid itself is not getting the update somehow. Let me know if you need any more information.

— Reply to this email directly, view it on GitHubhttps://github.com/episphere/questionnaire/issues/388#issuecomment-2246297072, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATJL76RUTMFR3N4OSYMHTHTZN27XBAVCNFSM6AAAAABK7O6LPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBWGI4TOMBXGI. You are receiving this because you were mentioned.Message ID: @.**@.>> External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.


Information in this e-mail may be confidential. It is intended only for the addressee(s) identified above. If you are not the addressee(s), or an employee or agent of the addressee(s), please note that any dissemination, distribution, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender of the error.

anthonypetersen commented 1 month ago

@guinevere83 to clarify, you're expecting to see a lower age range because you went back and selected 14 instead of 19?

guinevere83 commented 1 month ago

Correct - if I had selected 14 in the first place, I would see that lower age range.

anthonypetersen commented 1 month ago

is ALCOHOL4 the question you're referring to that you enter age?

guinevere83 commented 1 month ago

Yep that's the one.

JoeArmani commented 1 month ago

@boyd-mj @guinevere83 This grid display issue (the item this conversation pivoted to) should be resolved as of this morning. How we tested: (1) set age 19 (2) navigated to grid (3) navigated back and set age 14 (4) navigated to grid

First pass, age 19:

Screenshot 2024-07-26 at 12 06 14 PM

Second pass, age 14:

Screenshot 2024-07-26 at 12 06 49 PM
boyd-mj commented 1 month ago

Thanks @JoeArmani . @guinevere83 is currently testing.

boyd-mj commented 1 month ago

@JoeArmani this appears to be fixed based on our backend testing in dev. Thanks!

JoeArmani commented 1 month ago

Excellent. Thanks @boyd-mj.

@m-j-horner I'm just making sure you receive this notification, too. I'll close this one as well.