episphere / questionnaire

1 stars 2 forks source link

Superscript for Spanish Module 2 PREG4 #404

Closed woodruffr closed 3 months ago

woodruffr commented 3 months ago

Although some attention was given to the PREG4 superscript in https://github.com/episphere/questionnaire/issues/377, the updated value does not appear as a superscript; it is in normal text. Both the English and Spanish documents have the st or o as a superscript. In Dev testing we noticed it is not raised. If it should be a superscript, then Tony will have to make this change. We can't do it in the markdown, since {##} is a function that NCI implemented. I'm assuming that this issue also appeared the last time the English M2 was tested, but we do not have those records to compare.

cusackjm commented 3 months ago

@anthonypetersen are you able to make the values superscript

anthonypetersen commented 3 months ago

@m-j-horner was superscript a requirement? I don't think we superscript the English ordinals

m-j-horner commented 3 months ago

@anthonypetersen Correct, we did not superscript the English ordinals in the past.

If you have bandwidth and time to do superscripting of ordinals in English and Spanish for August, then great. Otherwise, let's move this to low priority in the bucket of "nice things to have" for user experience.

anthonypetersen commented 3 months ago

This has been added as an enhancement in another issue (https://github.com/episphere/connect/issues/926), closing.