episphere / questionnaire

1 stars 2 forks source link

Seeing SECSMLF questions for ages older than my participant #71

Closed cusackjm closed 2 years ago

cusackjm commented 2 years ago

testing 4/15 participant is 55, but I am seeing SECSMLFG (ages 60-69) and SECSMLFH (ages 70 and older)

boyd-mj commented 2 years ago

@cusackjm & @FrogGirl1123 we'll look into this, but I didn't think testing for M3 was supposed to start until the beginning of next week? FYI, there is an issue currently with the ALCLIFE grids in the transformed markup. I sent an email to Nicole and we'll be following up with a suggested DD change to address it. Once we have the updated JSON we will need to redeliver.

guinevere83 commented 2 years ago

Hmm, I'm not seeing that in my own testing:

image

Do you have a list of your response to previous questions in the module? I'll see if I can reproduce it if I know your testing path.

boyd-mj commented 2 years ago

@cusackjm just following up to see if you saw Gwen's response above? Thanks.

cusackjm commented 2 years ago

@boyd-mj I saw it in Dev on 4/15 around 2:45 has any change been made since then?

boyd-mj commented 2 years ago

No

cusackjm commented 2 years ago

I saw it while testing here: isabelleintersex@gmail.com Connect ID: 8011441974 and here: taratdrp@gmail.com Connect ID: 6697891999

@KELSEYDOWLING7 saw it here: dcegdaniel@gmail.com Connect ID: 4235365942

KELSEYDOWLING7 commented 2 years ago

I also saw it here: ivaniteb5@gmail.com Connect ID: 4061436541

guinevere83 commented 2 years ago

Could I see the values that were being entered for this testing? There was a document in this issue that was helpful in at least seeing the testing path: https://github.com/episphere/questionnaire/issues/67

Might help me see if there are unexpected variables affecting this grid.

cunnaneaq commented 2 years ago

I'm not sure if this helps, but when testing as a 44 year old, I noticed that the age ranges that aren't supposed to be showing are showing up as "50-44" and "60-44." The "70 and older" is present too, but doesn't have a range. (email: aqcunnane@aol.com, Connect ID: 1217779307)

Screen Shot 2022-04-21 at 4 21 14 PM

KELSEYDOWLING7 commented 2 years ago

That is similar to what I was seeing as well. For one scenario Age 45 (as put in enrollment) was confirmed, and I saw age 45-60 for the second to last, and "70 and older for the last". The second scenario I answered no to age verification and entered "55". The third to last question said "50-54", the second to last said 54-60, and the last said "70 and older".

cusackjm commented 2 years ago

issue still present in testing 4/29/22 account: 609-576-3460 Connect ID: 9393372061

boyd-mj commented 2 years ago

After additional review, we could not identify a markup issue or recreate the error. We are wondering if it has something to do with the way the valueordefault function is performing:

|grid?|id="GRID_SECSMLF2"|Thinking about your usual adult life, about how often were you around the tobacco smoke of others, for example in your home, work, or school?|[

[SECSMLF2A] Age 0 to {$e:min(17,valueOrDefault("AGE","age",100)) }; [SECSMLF2B,displayif=greaterThan(difference(isDefined(AGE,age),2),18)] Age 18 to {$e:min(24,valueOrDefault("AGE","age",100)) }; [SECSMLF2C,displayif=greaterThan(difference(isDefined(AGE,age),2),25)] Age 25 to age {$e:min(29,valueOrDefault("AGE","age",100)) }; [SECSMLF2D,displayif=greaterThan(difference(isDefined(AGE,age),2),30)] Age 30 to age {$e:min(39,valueOrDefault("AGE","age",100)) }; [SECSMLF2E,displayif=greaterThan(difference(isDefined(AGE,age),2),40)] Age 40 to age {$e:min(49,valueOrDefault("AGE","age",100)) }; [SECSMLF2F,displayif=greaterThan(difference(isDefined(AGE,age),2),50)] Age 50 to age {$e:min(59,valueOrDefault("AGE","age",100)) }; [SECSMLF2G,displayif=greaterThan(difference(isDefined(AGE,age),2),60)] Age 60 to age {$e:min(69,valueOrDefault("AGE","age",100)) }; [SECSMLF2H,displayif=greaterThanOrEqual(isDefined(AGE,age),70)] Age 70 and older;]|

(0:Every day, at least 2 hours each day) (1:Every day, less than 2 hours each day) (2:Most days of the week) (3:A few days per week) (4:One day per week) (5: A few days per month) (6: One day per month) (7: few days per year) (44: Never)|

@danielruss & @naiyume when age and AGE are both defined, the displayifs don't seem to function as expected. Could you please take a look? This is the only outstanding high priority issue for Module 3.

danielruss commented 2 years ago

image

not seeing the problem either. @naiyume is it an issue in the PWA?

danielruss commented 2 years ago

image

QUEST is working exactly as expected when you give it both age and AGE. From the markdown {$e:min(17,valueOrDefault("AGE","age",100)) }. <- valueOrDefault picks AGE, if AGE doesnt exist, it chooses age, if that doesn't exist then return 100.

boyd-mj commented 2 years ago

This issue is being addressed here: https://github.com/episphere/quest/issues/403

cunnaneaq commented 2 years ago

Looks good to me in testing 5/23 - @cusackjm @KELSEYDOWLING7 can you confirm before closing?

cusackjm commented 2 years ago

confirmed testing 5/23/22

woodruffr commented 2 years ago

Julie,

Has the spacing issue in Quest Github 403 been resolved? Is the "Looks good" just refer to the age ranges themselves or the age ranges and spacing of the age ranges?

Thanks, Rose

cusackjm commented 2 years ago

the spacing issue looked resolved to me and aileen

KELSEYDOWLING7 commented 2 years ago

Looks good for me as well