epispot / EpiJS

A toolset for analyzing and creating epidemiological models.
https://epi.js.org
GNU General Public License v3.0
5 stars 2 forks source link

Feature - Extending Compartments #28

Closed Quantalabs closed 3 years ago

Quantalabs commented 3 years ago

EpiJS's comp module currently has only the Idiom class, so extending this module would be extremely useful for people who don't know the equations behind each compartment.

Goals:

These all should have the same format, so the model module can compile the models no matter the compartment:

CLASS - Compartment
     - constructor ()
     - get_data (key)

The constructor can have an optional equation parameter, and the pre-build compartments can have extra features for extensibility.

Quantalabs commented 3 years ago

I'll start work on the new-model branch, though contributions are still welcome!

/claim

github-actions[bot] commented 3 years ago

Thank you @Quantalabs for claiming this issue! 🎉

Please reference this issue when you submit your Pull Request and make sure you follow the contributing guidelines.

Quantalabs commented 3 years ago

I'll leave the custom sub-compartments out for a future release, and submit the PR and close the issue without it.

Quantalabs commented 3 years ago

PR will be submitted soon