search

epispot / EpiJS

A toolset for analyzing and creating epidemiological models.
https://epi.js.org
GNU General Public License v3.0
5 stars 2 forks source link

[Bug] Switch from webpack to browserify #43

Closed Quantalabs closed 3 years ago

Quantalabs commented 3 years ago

Describe the bug Webpack's bundling of dependencies and code changes all function names, including those used in epijs. Browserify allows bundling of all dependencies and still allow for the code to be intact.

To Reproduce Go to the web/index.min.js and search for "sir" or any other function/class name in EpiJS. It most likely isn't there.

Expected behavior These functions/classes should show up, to allow for users on the web to access these commands.

Screenshots Checking for the sir function in the pre module: Checking for the `sir` function in the `pre` module Checking for the Idiom function in the comp module: Checking for the `Idiom` function in the `comp` module

Additional context Browserify will be added on the patch-43 branch.

Quantalabs commented 3 years ago

I'll start work after #41 is merged: /claim

github-actions[bot] commented 3 years ago

Thank you @Quantalabs for claiming this issue! 🎉

Please reference this issue when you submit your Pull Request and make sure you follow the contributing guidelines.

Quantalabs commented 3 years ago

PR submitted, however, this will introduce a deprecation:

sir()

becomes:

EpiJS.pre.sir()

This applies to all functions and classes, in the format:

EpiJS.[module].[function]