epiverse-trace / blueprints

Software development blueprints for epiverse-trace
https://epiverse-trace.github.io/blueprints
Other
4 stars 4 forks source link

Mention Tidyteam code review doc and clarify details #41

Closed joshwlambert closed 1 year ago

joshwlambert commented 1 year ago

The information on code reviews in the current blueprints document is more high-level and lacks clear guidelines on the Epiverse-TRACE code review principles.

Given Epiverse-TRACE conducts code reviews in a similar process to the Tidyteam, and they happen to have a nice document outlining their principles and ways of working we should link to this.

In addition to linking to the Tidyteam document, I think adding some further points of clarification would be useful. For example, previous confusion over whose responsibility it is to resolve conversations in code reviews. Therefore a few bullet points outlining some common code review tasks that may be ambiguous without explanation.