search

epiverse-trace / blueprints

Software development blueprints for epiverse-trace
https://epiverse-trace.github.io/blueprints
Other
2 stars 3 forks source link

Revise plotting page #76

Closed chartgerink closed 3 months ago

chartgerink commented 4 months ago

This PR against the plotting branch is an attempt to consolidate some of the discussions had in PR https://github.com/epiverse-trace/blueprints/pull/44. I am doing this first to get sign-off from the original contributor as this is quite the change.

@joshwlambert - I wanted to be sure to give you a first read and the opportunity to say whether this is okay with you (or not). I rewrote the page quite a bit without your approval, so feel free to decline. I wanted to ensure I could pull this along the finish line in case you approve of these changes. 😊

joshwlambert commented 4 months ago

@chartgerink thanks for the updates, it's looking in better shape and seems clearer. I've left a few comments in the diff and I'm happy to discuss next steps.

chartgerink commented 4 months ago

Thanks @joshwlambert - sorry I haven't gotten around to this. I'm unable to get to it for the next two weeks but have it planned for the (early) week of the 18th.

joshwlambert commented 4 months ago

@chartgerink no problem. No urgent reason to merge this from my side so happy to discuss whenever you're free.

chartgerink commented 3 months ago

Thanks @joshwlambert - I resolved all your suggestions and reinvited your review. Happy to discuss this synchronously as well to ensure alignment 😊

chartgerink commented 3 months ago

Thanks @joshwlambert 🙏 This branch is merging into your branch, so I will be sure to invite them over on that PR #44.