Minor improvements to helper/checker functions

epiverse-trace / epichains

[Under active development] Methods for simulating and analysing the sizes and lengths of infectious disease transmission chains from branching process models

https://epiverse-trace.github.io/epichains/

Other

5 stars 2 forks source link

Minor improvements to helper/checker functions #192

Closed jamesmbaazam closed 7 months ago

jamesmbaazam commented 7 months ago

This PR closes #157 by:

Using switch() instead of ifelse() ladders for doing choice operations
Prefixes all internal helper and checker functions with a . to align with other Epiverse-TRACE packages, e.g., superspreading, simulist, and epidemics. This is mostly for visual effects and to prevent (rare) NAMESPACE clashes.

Bullet 3 in the linked issue is solved by abstracting away the suggested change with the function update_chain_stat(), which now uses switch().

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@0941451). Click here to learn what that means.

:exclamation: Current head 300f03f differs from pull request most recent head d642146. Consider uploading reports for the commit d642146 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #192 +/- ## ======================================= Coverage ? 99.43% ======================================= Files ? 8 Lines ? 529 Branches ? 0 ======================================= Hits ? 526 Misses ? 3 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.